From 6ce3d540e8c3825b507920b51d0f47a593d1a7cd Mon Sep 17 00:00:00 2001 From: yuhan6665 <1588741+yuhan6665@users.noreply.github.com> Date: Sun, 24 May 2020 11:09:11 -0400 Subject: [PATCH 1/2] Remove config item in drawer The drawer is attached to MainActivity. When user see the drawer, the MainActivity must be active. Showing an menu item to launch itself is confusing. --- .../src/main/kotlin/com/v2ray/ang/ui/BaseDrawerActivity.kt | 5 +---- V2rayNG/app/src/main/res/menu/menu_drawer.xml | 4 ---- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/V2rayNG/app/src/main/kotlin/com/v2ray/ang/ui/BaseDrawerActivity.kt b/V2rayNG/app/src/main/kotlin/com/v2ray/ang/ui/BaseDrawerActivity.kt index e427c7ed..6227f9ac 100644 --- a/V2rayNG/app/src/main/kotlin/com/v2ray/ang/ui/BaseDrawerActivity.kt +++ b/V2rayNG/app/src/main/kotlin/com/v2ray/ang/ui/BaseDrawerActivity.kt @@ -55,7 +55,6 @@ abstract class BaseDrawerActivity : BaseActivity() { this@BaseDrawerActivity, R.anim.fade_in, R.anim.fade_out).toBundle() var activityClass: Class<*>? = null when (mItemToOpenWhenDrawerCloses) { - R.id.server_profile -> activityClass = MainActivity::class.java R.id.sub_setting -> activityClass = SubSettingActivity::class.java R.id.settings -> activityClass = SettingsActivity::class.java R.id.logcat -> { @@ -195,9 +194,7 @@ abstract class BaseDrawerActivity : BaseActivity() { true } - if (MainActivity::class.java.isAssignableFrom(javaClass)) { - navigationView.setCheckedItem(R.id.server_profile) - } else if (SubSettingActivity::class.java.isAssignableFrom(javaClass)) { + if (SubSettingActivity::class.java.isAssignableFrom(javaClass)) { navigationView.setCheckedItem(R.id.sub_setting) } else if (SettingsActivity::class.java.isAssignableFrom(javaClass)) { navigationView.setCheckedItem(R.id.settings) diff --git a/V2rayNG/app/src/main/res/menu/menu_drawer.xml b/V2rayNG/app/src/main/res/menu/menu_drawer.xml index 54994c7b..729107fb 100644 --- a/V2rayNG/app/src/main/res/menu/menu_drawer.xml +++ b/V2rayNG/app/src/main/res/menu/menu_drawer.xml @@ -6,10 +6,6 @@ - Date: Sun, 24 May 2020 11:13:12 -0400 Subject: [PATCH 2/2] Make drawer item unchecked Current checked item is not consistent with the active activity. In fact, we don't need checked state. This is a standard behavior. You can find in apps like Google Playstore. --- V2rayNG/app/src/main/res/menu/menu_drawer.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/V2rayNG/app/src/main/res/menu/menu_drawer.xml b/V2rayNG/app/src/main/res/menu/menu_drawer.xml index 729107fb..69cc38b8 100644 --- a/V2rayNG/app/src/main/res/menu/menu_drawer.xml +++ b/V2rayNG/app/src/main/res/menu/menu_drawer.xml @@ -4,8 +4,7 @@ tools:showIn="navigation_view"> + android:id="@+id/group_main">